-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature skip all button implemented #75
Changes from all commits
3c8c46f
78f26e5
6840dce
98be3b1
c3d3af4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -414,6 +414,7 @@ | |
} | ||
} | ||
|
||
showButton('jpwSkipAll'); | ||
showButton('jpwPrevious'); | ||
showButton('jpwNext'); | ||
showButton('jpwFinish'); | ||
|
@@ -889,6 +890,10 @@ | |
/* Close and finish tour buttons clicks */ | ||
$(document).on('click', '#jpwClose, #jpwFinish', methods.close); | ||
|
||
/* Skip All to skip all tour steps | ||
*/ | ||
$(document).on('click', '#jpwSkipAll', methods.close); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess we can probably move this selector into the one above (ie with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oooppps! okay i missed that. |
||
|
||
/* Next button clicks | ||
*/ | ||
$(document).on('click', '#jpwNext', function() { | ||
|
@@ -1038,6 +1043,12 @@ | |
// function which returns a boolean value | ||
show: true | ||
}, | ||
jpwSkipAll: { | ||
i18n: 'Skip All ⏩', | ||
show: function() { | ||
return isFirstStep(); | ||
} | ||
}, | ||
jpwNext: { | ||
i18n: 'Next →', | ||
// Function which resolves to a boolean | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should default this to
false
, chances are that existing users probably won't want this functionality to be turned on by default.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay that's okay i can do that.