Fix deprecation warnings #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiegley
approved these changes
Mar 21, 2025
|
I suppose now is the time to drop all support for Coq < 8.19? |
|
It's really not necessary because it compiles on Rocq 9.0 even without the changes. Users can silence the deprecation warning if they want. you can drop support for lower versions of Coq when this change becomes necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coq 8.19 deprecates the use of the
%symbol in theArgumentscommand for managing scope, and advises to switch to%_. This PR implements this.This PR is not necessary to compile this library on Coq 8.20 or Rocq 9.0; it compiles without any failures.
Coq 8.19 is the first Coq version to support the
%_operator inArguments, so all the earlier versions will fail to build. Coq 8.19 was released in January 2024.