Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] onAudioTracks and getAudioTracks not working #112

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[BUG] onAudioTracks and getAudioTracks not working #112

merged 2 commits into from
Jan 22, 2025

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Add missing listener for Android tracks callbacks
  • Modernize getAudioTracks for iOS v4 objects

Why is this Pull Request needed?

  • Android onAudioTracks not firing
  • getAudioTracks broken on iOS

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner December 23, 2024 18:12
@Jmilham21 Jmilham21 requested a review from edougher January 6, 2025 21:22
edougher
edougher approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@edougher edougher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Jmilham21 Jmilham21 merged commit b2ed1ef into master Jan 22, 2025
@Jmilham21 Jmilham21 deleted the bug/onAudioTracks-not-working branch January 22, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edougher edougher edougher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jmilham21 @edougher