Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] App crash when re-entering full screen from a player that was previously sent into PIP mode whilst full screen #94

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Fix fatal crash when going into fullscreen AFTER being in fullscreen and putting player into PiP

Why is this Pull Request needed?

  • Fatal crash

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner October 15, 2024 17:47
@Jmilham21 Jmilham21 requested a review from edougher October 22, 2024 16:52
Copy link
Collaborator

@edougher edougher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Jmilham21 Jmilham21 merged commit 80059bc into master Oct 23, 2024
@Jmilham21 Jmilham21 deleted the bug/app-crash-re-enter-fullscreen-after-pip branch October 23, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants