Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run build to remove console error #25

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

smitser
Copy link
Contributor

@smitser smitser commented Jun 8, 2023

This PR will...

resolve issue NextJS obscure 'props' error mentioning an unexpected console error of the props.

Why is this Pull Request needed?

To remove the unexpected console error.

Are there any points in the code the reviewer needs to double check?

No, only the build script was executed.

Are there any Pull Requests open in other repos which need to be merged with this?

No.

Addresses Issue(s):

/

@jwplayer-robot
Copy link

Can one of the admins verify this patch?

@simpros
Copy link

simpros commented Jun 21, 2023

I would also need this patch 👍

Copy link

@lukedanielson lukedanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smitser PR removes obscure console error. Approved!

@jdunningjwp jdunningjwp merged commit 1e57c0a into jwplayer:main Jul 3, 2023
@smitser smitser deleted the fix-console-error branch July 10, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants