Add TypeScript typings #29
Open
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
types/jwplayer-react.d.ts
Outdated
| @@ -99,7 +98,7 @@ declare module '@jwplayer/jwplayer-react' { | |||
| config?: JWPlayerConfig; | |||
| } | |||
|
|
|||
| const JWPlayerComponent = React.Component<JWPlayerProps & React.HTMLProps<'video'>>; | |||
| const JWPlayerComponent: ComponentType<JWPlayerProps & HTMLProps<'video'>>; | |||
There was a problem hiding this comment.
Why not use HTMLProps<HTMLVideoElement> instead of HTMLProps<'video'>> ?
The latter will hardly pick all the relevant types for a video element
There was a problem hiding this comment.
@amowu could you please update? Would be awesome to make this available
|
Minor update needed to See #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Add
@jwplayer/jwplayer-reactTypeScript typesWhy is this Pull Request needed?
Cannot find module '@jwplayer/jwplayer-react' or its corresponding type declarations.
Are there any points in the code the reviewer needs to double check?
After
npm publish, you can use tools like CodeSandbox to create a React TypeScript project to check whetherimport JWPlayer from '@jwplayer/jwplayer-react'will still display this error message.Are there any Pull Requests open in other repos which need to be merged with this?
N/A
Addresses Issue(s):
#4