Fix / waiting for payment PPV/TVOD offers #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
AntonLantukh and
dbudzins
as code owners
|
Visit the preview URL for this PR (updated for commit 4cfbde8): https://ottwebapp--pr541-fix-waiting-for-paym-3vrp1mm6.web.app (expires Sat, 06 Jul 2024 10:03:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
ChristiaanScheermeijer
added
the
JWP Audit
langemike
approved these changes
Jun 4, 2024
royschut
approved these changes
Jun 5, 2024
packages/ui-react/src/components/WaitingForPayment/WaitingForPayment.tsx
Outdated
Show resolved
Hide resolved
AntonLantukh
reviewed
Jun 6, 2024
AntonLantukh
approved these changes
Jun 6, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #518. I've updated the formatted
offerIdin the JWP integration. TheofferIdis now composed of the offer prefix, asset ID, and access fee ID. The composed offer ID is added to the URL when the user is sent to the waiting for payments modal. The integration is responsible for retrieving the asset ID when needed.I also encountered a problem because the
getSubscriptionSwitchesmethod threw an error in theinitialiseOffersmethod. This caused the query to retry a few times before resolving, making the Choose offers modal really slow.The third change is that the welcome modal isn't shown to users buying PPV access since the welcome modal shows a message stating "You now have access to all content", which isn't true when buying access to a single item.