-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OWA-79] feat(i18n): add translations #602
Conversation
Visit the preview URL for this PR (updated for commit bba1a37): https://ottwebapp--pr602-feature-owa-79-add-t-wemqd5g1.web.app (expires Sat, 19 Oct 2024 12:23:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
Great work. Could you maybe describe the scope of this ticket a bit more? |
@baukef Definitely! In the dashboard, we have the However, we did not integrate this into the OTT Web App yet, so these custom params translations are not retrieved. What this ticket is trying to do is to retrieve these custom params and transform the media item: if we for instance have |
It would be awesome if you could extend this pattern to playlists as well. This is not yet available in the dashboard, but we could still use the custom parameters on playlists. The main goal would be for the navigation (library) items to be translated this way. |
@baukef agree. It should probably be on a shelf level Shelves have titles as well. The same goes for menu items. |
This is heading in the right direction. I suggest using |
packages/ui-react/src/pages/ScreenRouting/MediaScreenRouter.tsx
Outdated
Show resolved
Hide resolved
@AntonLantukh @ChristiaanScheermeijer Code is ready and working, feel free to have another look 🚀 |
Hi @ChristiaanScheermeijer 👋🏻 The feature is ready, I fixed all the feedback Anton had and I added translations for all media on Blender |
Description
Steps completed:
According to our definition of done, I have completed the following steps: