Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat / Replace hard-coded English string with translatable strings #650

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

langemike
Copy link
Collaborator

This change adds missing translations for the OTT platform. We believe that there are no hard-coded English labels present anymore in the code. This means we 100% of the text occurrences can be translated.

Adds:

  • Translations for credit card (number + expiry date)
  • Abbreviations for hours and minutes
  • Translated open/close aria label for search

Let me know if there is still a hard-coded English string anywhere.

Ticket: OTT-2762

Copy link

Visit the preview URL for this PR (updated for commit b93174f):

https://ottwebapp--pr650-feat-missing-transla-9h842735.web.app

(expires Sat, 21 Dec 2024 15:45:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

Copy link
Collaborator

@royschut royschut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

About the abbreviation: I think in some languages the number can come after the abbr, and in other languages they have a space between them (1hr, 1 h French, and I think something like h 1 in Arabic?). That could be fixed if we add the number to the translation {{count}}hr. But perhaps we can implement that later, this PR makes it much better.

@langemike
Copy link
Collaborator Author

That could be fixed if we add the number to the translation {{count}}hr. But perhaps we can implement that later, this PR makes it much better.

Good idea. I will create a ticket for this in our backlog. Since I already introduced the new (de/fr/nl) languages based on the current approach, it is quite a hassle to synchronize this across branches. Do-able of course, but my current priority is to get these languages to new platforms first.

Copy link
Contributor

@CarinaDraganJW CarinaDraganJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@langemike langemike merged commit 9d4b6a3 into develop Nov 25, 2024
10 checks passed
@langemike langemike deleted the feat/missing-translations branch November 25, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants