Chore / add cheerio resolution #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
langemike,
AntonLantukh and
royschut
|
Visit the preview URL for this PR (updated for commit 79a5078): https://ottwebapp--pr661-fix-add-cheerio-reso-vzpnr5nl.web.app (expires Thu, 16 Jan 2025 15:55:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
AntonLantukh
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
cheeriohas recently releasedv1.0.0with breaking changes. The issue is thati18next-parserdepends oncheerio@^1.0.0-rc.2which allows the upgrade tov1.0.0when runningyarn upgrade.This has been fixed the i18next-parser v9.0.2 release, but we didn't upgrade this package yet.