-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SPDX identifier in POMs #979
base: master
Are you sure you want to change the base?
Conversation
This replaces the custom name with an SPDX identifier to enable tooling to automatically detect the correct license. See https://spdx.org/licenses/Apache-2.0.html
Just checked the Ci failure. It's unrelated to this change and instead seems to be a spurious issue while downloading the JDK. |
@TheMrMilchmann I'll re-run the job, looks like that might have been a GH Actions infra issue? |
Just tried to run it myself as well - the setup JDK task is failing. Seems to be due to: Line 23 in 2ad964a
That project is here: https://github.com/oracle-actions/setup-java But we're referencing I wonder: @TheMrMilchmann can you update the What I don't understand is that it was working until recently, so maybe Oracle stopped hosting the file? Not sure. |
There does indeed seem to be a version mismatch. From the failed build:
Definitely trying something with JDK 21 instead of 17. I looked in the old version 1.1.0 jdk.java.net-uri.properties file and downloaded the referenced file for JDK 17 to my local system just now:
and then verified the file:
So it seems that the file is still there, and I'm assuming that changing the uses: oracle-actions/[email protected] |
This appears to be intentional oracle-actions/setup-java#94 (comment). I'm currently travelling but can pin the version on Thursday. |
This replaces the custom name with an SPDX identifier to enable tooling to automatically detect the correct license. Using an SPDX identifier is recommended by the official Maven documentation.
See https://spdx.org/licenses/Apache-2.0.html