Skip to content

Commit

Permalink
Remove flake8 (SatelliteQE#15877)
Browse files Browse the repository at this point in the history
  • Loading branch information
ogajduse authored and jyejare committed Oct 19, 2024
1 parent 7a676f2 commit 51eac31
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
8 changes: 4 additions & 4 deletions docs/code_standards.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ Black

Linting

* All code will be linted to black-compatible `PEP8`_ standards using `flake8`_.
* In the root of the **Robottelo** directory, run :code:`flake8 .`
* If flake8 returns errors, make corrections before submitting a pull request.
* All code will be linted to black-compatible `PEP8`_ standards using `ruff linter`_.
* In the root of the **Robottelo** directory, run :code:`ruff check .`
* If ruff linter returns errors, make corrections before submitting a pull request.
* pre-commit configuration is available, and its use is strongly encouraged in local development.

Docstrings
Expand Down Expand Up @@ -146,7 +146,7 @@ Categorize each standard into how strictly they are enforced


.. _PEP8: http://legacy.python.org/dev/peps/pep-0008/
.. _flake8: http://flake8.readthedocs.org/
.. _ruff linter: https://docs.astral.sh/ruff/linter/
.. _testimony: https://github.com/SatelliteQE/testimony
.. _sphinx: http://sphinx-doc.org/markup/para.html
.. _properly format strings: https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
Expand Down
4 changes: 2 additions & 2 deletions docs/committing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ documented, it doesn’t exist.
In order to ensure you are able to pass the Travis CI build, it is recommended
that you run the following commands in the base of your Robottelo directory.::

$ flake8 .
$ ruff check .
$ make test-docstrings
$ make test-robottelo

:code:`flake8` will ensure that the changes you made are not in violation of
:code:`ruff linter` will ensure that the changes you made are not in violation of
PEP8 standards. If the command gives no output, then you have passed. If not,
then address any corrections recommended.

Expand Down
2 changes: 1 addition & 1 deletion requirements-optional.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# For running tests and checking code quality using these modules.
flake8==7.1.1
pytest-cov==5.0.0
redis==5.0.8
pre-commit==3.8.0
ruff==0.5.7

# For generating documentation.
sphinx==8.0.2
Expand Down
1 change: 0 additions & 1 deletion tests/foreman/endtoend/test_api_endtoend.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
from robottelo.utils.issue_handlers import is_open

API_PATHS = {
# flake8:noqa (line-too-long)
'activation_keys': (
'/katello/api/activation_keys',
'/katello/api/activation_keys',
Expand Down

0 comments on commit 51eac31

Please sign in to comment.