-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial kof documentation proposal #94
base: main
Are you sure you want to change the base?
Conversation
Initial version of the docs for KOF to be included in the k0rdent documentation.
This comment was marked as resolved.
This comment was marked as resolved.
docs/kof-into.md
Outdated
@@ -0,0 +1,278 @@ | |||
# k0rdent Observability and FinOps (KOF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename kof-into.md
looks like a typo, please rename it to either:
kof-intro.md
kof-info.md
kof.md
- I'd prefer this simple one.
Also please update the PR title in the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we discussed, we'll rename the file before the merge to avoid suggestions becoming outdated
name: kof-storage-cluster | ||
namespace: kof | ||
spec: | ||
template: kof-storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but this template: kof-storage
looks alike, but not compatible with template: kof-storage
we're using here: https://github.com/k0rdent/kof/blob/f3520f76373672cd0325aa09d85210f0f268f1e3/demo/cluster/aws-storage.yaml#L40
And the same for template: kof-collectors
below.
|
||
``` yaml | ||
apiVersion: grafana.integreatly.org/v1beta1 | ||
kind: GrafanaDatasource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, the same compatibility question:
https://github.com/k0rdent/kof/blob/f3520f76373672cd0325aa09d85210f0f268f1e3/charts/kof-mothership/templates/grafana/metrics-datasource.yaml#L22-L34
fixed typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All agreed.
This reverts commit d8f7458.
Co-authored-by: Denis Ryzhkov <[email protected]>
Co-authored-by: Denis Ryzhkov <[email protected]>
Co-authored-by: Denis Ryzhkov <[email protected]>
Co-authored-by: Denis Ryzhkov <[email protected]>
As decided above, I'll continue from here in the same branch/PR. |
Sounds good. |
…about each helm chart, demo of grafana and sveltos
Initial version of the docs for KOF to be included in the k0rdent documentation. This is taken from the wiki and repo docs, and will need review by the KOF team.
Closes #92