Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when spec.core is unset in custom Management #1058

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fix panic when spec.core is unset in custom Management #1058

merged 1 commit into from
Feb 10, 2025

Conversation

eromanova
Copy link
Contributor

  • Fix panic on enableAdditionalComponents when spec.core is unset
  • Update getWrappedComponents to handle the case when spec.core is unset without breaking

Closes #939

@eromanova
Fix panic when spec.core is unset in custom Management
969bf39 
* Fix panic on `enableAdditionalComponents` when `spec.core` is unset
* Update `getWrappedComponents` to handle the case when `spec.core` is
  unset without breaking

Closes k0rdent#939
@eromanova eromanova self-assigned this Feb 10, 2025
@eromanova eromanova merged commit dfcdb4b into k0rdent:main Feb 10, 2025
6 checks passed
@eromanova eromanova deleted the fix-panic branch February 10, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerospiel zerospiel zerospiel approved these changes

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

Assignees

@eromanova eromanova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] nil pointer panic error if spec.core.kcm value is not set in custom Management object
2 participants
@eromanova @zerospiel