-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular infrastructure providers using Sveltos templates #874
base: main
Are you sure you want to change the base?
Conversation
@@ -200,7 +201,7 @@ func (r *ReleaseReconciler) ensureManagement(ctx context.Context) error { | |||
if err != nil { | |||
return err | |||
} | |||
mgmtObj.Spec.Providers = hmc.GetDefaultProviders() | |||
mgmtObj.Spec.Providers = providers.List() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File internal/providers/azure.go
is still needed due to a need of populating this list on first start of manager
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the approaches that can allow removal of mentioned file is taken in https://github.com/k0rdent/kcm/pull/833/files
Specifically:
- YAML provider loader, just without Lua parts
- Actual YAML provider definition, also ignore Lua parts here
- YAML loader in
manager
start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or any other way that can populate list with extra values during manager
start
Or maybe we could rethink logic behind that list altogether
internal/providers/azure.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -41,3 +41,57 @@ spec: | |||
kind: AzureClusterIdentity | |||
name: azure-cluster-identity | |||
namespace: ${NAMESPACE} | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Template render errors are available from ClusterSummary
kubectl -n ${NAMESPACE} get ClusterSummary some-object-name -o yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ac61def
to
e92e0cb
Compare
Modular infrastructure providers using Sveltos templates