-
Notifications
You must be signed in to change notification settings - Fork 86
make drain option configuable #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f41d0d4
to
a9cd268
Compare
phase/upgrade_workers.go
Outdated
|
||
gracePeriod := upgradeSettings.DrainGracePeriod | ||
if gracePeriod == "" { | ||
gracePeriod = "30" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed to changed default value.
a9cd268
to
768204e
Compare
I think the config syntax needs some further thinking.
|
Cherry-pick from #725 Signed-off-by: Keiji Yoshimi <[email protected]>
fix #724