Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator [O] victoriametrics-operator (0.49.1) #5341

Closed
wants to merge 2 commits into from

Conversation

tomasbakk
Copy link
Collaborator

@tomasbakk tomasbakk commented Nov 22, 2024

This PR is meant to fix the broken bundle that is affecting releasing of k8s operators.


Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

Copy link
Contributor

@victoriametrics-bot,@Haleygo,@AndrewChubatiuk,@f41gh7 , please approve as you are original reviewer(s).

  • To add more contributors to ci.yaml follow instruction here.
  • To approve follow instruction here

@github-actions github-actions bot changed the title fix-bundle-victoriametrics operator [O] victoriametrics-operator (0.49.1) Nov 22, 2024
@tomasbakk
Copy link
Collaborator Author

tomasbakk commented Nov 25, 2024

Hmm. So it is not possible to fix it by either deleting the latest bundle and adding it again with correct replaces, nor with changing the replaces strategy for the latest bundle either because of incorrect channel head . This warrants further investigation/debugging.

@tomasbakk tomasbakk force-pushed the fix-bundle-victoriametrics branch from 9568cfd to 169d023 Compare November 25, 2024 12:09
@AndrewChubatiuk
Copy link
Contributor

for some reason version sort is broken in traffic light test

Versions Count: CHANGED[0.10.0 0.11.0 0.12.1 0.12.2 0.13.1 0.14.1 0.15.2 0.16.0 0.17.1 0.17.2 0.18.0 0.18.1 0.18.2 0.19.0 0.19.1 0.20.1 0.21.0 0.22.0 0.22.1 0.23.3 0.24.0 0.25.0 0.25.1 0.26.2 0.27.2 0.29.1 0.32.0 0.32.1 0.33.0 0.39.4 0.4.0 0.46.2 0.46.3 0.46.4 0.47.0 0.47.2 0.47.3 0.48.3 0.48.4 0.6.1 0.7.3 0.8.0 0.9.1] REMOVED[]

it tries to run 0.9.1, which uses deprecated API

@tomasbakk
Copy link
Collaborator Author

tomasbakk commented Nov 25, 2024

for some reason version sort is broken in traffic light test

Versions Count: CHANGED[0.10.0 0.11.0 0.12.1 0.12.2 0.13.1 0.14.1 0.15.2 0.16.0 0.17.1 0.17.2 0.18.0 0.18.1 0.18.2 0.19.0 0.19.1 0.20.1 0.21.0 0.22.0 0.22.1 0.23.3 0.24.0 0.25.0 0.25.1 0.26.2 0.27.2 0.29.1 0.32.0 0.32.1 0.33.0 0.39.4 0.4.0 0.46.2 0.46.3 0.46.4 0.47.0 0.47.2 0.47.3 0.48.3 0.48.4 0.6.1 0.7.3 0.8.0 0.9.1] REMOVED[]

it tries to run 0.9.1, which uses deprecated API

yeah, I am trying to find out the reason why but to no avail yet. If I change the replaces strategy to see if it will align to the previous versions, it will fail on semver because OLM enforces strict Semantic versioning rules. New must progress forward from the channel head. Changing 0.49.1 replaces field breaks this rule because 0.49.1 is already indexed but is now out of order.
In case I try to remove either latest or 2 latest versions, it will fail on that one. It looks like it is picking up 9.1 as latest bundle to test and failing for incompatible max k8s version...
It might be possible to skip the pipeline entirely and rebuild the latest bundle via OPM and then re-run the PR only with changes to the replaces field. Since the bundle in the index would have correct value.

Copy link
Contributor

Dear @tomasbakk,
Your forked procject is not rebased

To fix this issue please rebase or execute following commands:

git clone https://github.com/k8s-operatorhub/community-operators /tmp/operators-repo
cd /tmp/operators-repo
git checkout origin/fix-bundle-victoriametrics
git remote add upstream https://github.com/k8s-operatorhub/community-operators -f
git pull --rebase upstream main

@Allda Allda force-pushed the fix-bundle-victoriametrics branch from f1b6bf7 to 6eceef2 Compare November 26, 2024 08:45
Copy link
Contributor

Dear @tomasbakk,
Your forked procject is not rebased

To fix this issue please rebase or execute following commands:

git clone https://github.com/k8s-operatorhub/community-operators /tmp/operators-repo
cd /tmp/operators-repo
git checkout origin/fix-bundle-victoriametrics
git remote add upstream https://github.com/k8s-operatorhub/community-operators -f
git pull --rebase upstream main

tomasbakk and others added 2 commits November 26, 2024 09:47
@AndrewChubatiuk
Copy link
Contributor

@tomasbakk I've removed too old versions and rebuilt index, suppose this PR can be closed

@tomasbakk
Copy link
Collaborator Author

Thank you. Yes, I will close the PR.

@tomasbakk tomasbakk closed this Nov 26, 2024
@tomasbakk
Copy link
Collaborator Author

@AndrewChubatiuk Just a quick note; release of your operator for the latest bundle failed because there are some other operators out of sync, due to the recent problems. I run the manual release of said bundles and after the workflow is finished, your recent bundles should be release as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants