Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "🌱 Making workflows not run on forks." #557

Merged
merged 1 commit into from
May 15, 2024

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented May 15, 2024

Reverts #540

as it breaks the image push actions
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/9091929799

[Invalid workflow file: .github/workflows/image-push-master.yml#L10](https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/9091929799/workflow)
The workflow is not valid. .github/workflows/image-push-master.yml (Line: 10, Col: 9): Unrecognized named-value: 'env'. Located at position 28 within expression: github.repository_owner == env.image-push-owner .github/workflows/image-push-master.yml (Line: 41, Col: 9): Unrecognized named-value: 'env'. Located at position 28 within expression: github.repository_owner == env.image-push-owner

Looks like jobs.<job_id>.if does not have access to the env context
https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability

cc @adilGhaffarDev , @Eoghan1232 , @SchSeba

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9092506522

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.1%

Totals Coverage Status
Change from base Build 9091929803: 0.0%
Covered Lines: 2060
Relevant Lines: 2743

💛 - Coveralls

@adilGhaffarDev
Copy link
Contributor

@zeeke I have a PR that fixes this: #558 please take a look

@adilGhaffarDev
Copy link
Contributor

@zeeke lets revert, for now, I don't want to block any PRs.
I added a fix and tried it on my fork, The image pushes passes (skipped) but push-manifest fails, I need to check that. https://github.com/adilGhaffarDev/sriov-network-device-plugin/actions/runs/9094211979

@adilGhaffarDev
Copy link
Contributor

/lgtm

@zeeke
Copy link
Member Author

zeeke commented May 15, 2024

@adilGhaffarDev thanks for checking that.

@Eoghan1232, @adrianchiris, @SchSeba Please take a look at this revert PR.

@zeeke zeeke merged commit d59e6ab into master May 15, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants