add support for draining single nodes #843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change if a single node needs to drain to make configure changes it will remove pods using SR-IOV devices, but in case if a reboot is needed we just go and reboot. This is an improvements from the skipDrain option we have in the sriovOperatorConfig where in case of only draining is needed to make the configuration change running pods using sriov will lost the VFs in runtime... Signed-off-by: Sebastian Sch <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 13242265777Details
💛 - Coveralls |
| @@ -22,6 +22,13 @@ type SriovNetworkPoolConfigSpec struct { | |||
| // even if maxUnavailable is greater than one. | |||
| MaxUnavailable *intstr.IntOrString `json:"maxUnavailable,omitempty"` | |||
|
|
|||
| // SkipDrainOnReboot defines if the operator should make a full no drain before reboot | |||
There was a problem hiding this comment.
What does "full no drain" mean?
| @@ -172,6 +178,7 @@ func (dr *DrainReconcile) tryDrainNode(ctx context.Context, node *corev1.Node) ( | |||
| } | |||
| reqLogger.Info("Max node allowed to be draining at the same time", "MaxParallelNodeConfiguration", maxUnv) | |||
| reqLogger.Info("Count of draining", "drainingNodes", current) | |||
| reqLogger.Info("Check Skip Drain on boot config", "SkipDrainOnReboot", nodePool.Spec.SkipDrainOnReboot) | |||
There was a problem hiding this comment.
skip drain on reboot ?
| // This is useful for single node deployments instead of using the skipDrain from the operatorConfig. | ||
| // This will allow the operator to drain pods using sriov devices when drain is needed on single node | ||
| // instead of just removing the VF's from running pods that is the case if skipDrain is used. | ||
| SkipDrainOnReboot bool `json:"skipDrainOnReboot,omitempty"` |
There was a problem hiding this comment.
to consider:
implicitly skip drain if reboot requested in case of a single node cluster.
|
deprecate in favor of #850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change if a single node needs to drain to make configure changes it will remove pods using SR-IOV devices, but in case if a reboot is needed we just go and reboot.
This is an improvements from the skipDrain option we have in the sriovOperatorConfig where in case of only draining is needed to make the configuration change running pods using sriov will lost the VFs in runtime...