Remove leader election for the operator #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
zeeke
reviewed
Feb 19, 2025
| @@ -48,9 +48,6 @@ import ( | |||
| sriovnetworkv1 "github.com/k8snetworkplumbingwg/sriov-network-operator/api/v1" | |||
| "github.com/k8snetworkplumbingwg/sriov-network-operator/controllers" | |||
| "github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/featuregate" | |||
| "github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/leaderelection" | |||
There was a problem hiding this comment.
I think we can delete this package completely
And this will increase our code coverage 🚀
There was a problem hiding this comment.
nice catch thanks!
for the operator we don't need a leader election. to avoid multiple instances running we change the upgrade policy to Recreate. We always deploy the sriov operator with replica 1 so no need really to have leader election Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
remove_leader_election
branch
from
cbf118a to
ca3bee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the operator we don't need a leader election.
to avoid multiple instances running we change the upgrade policy to Recreate.
We always deploy the sriov operator with replica 1 so no need really to have leader election