Remove ability to request a repair with no notifications from the v2 …

…repair endpoint.
k8ssandra · Oct 12, 2023 · da42b1a · da42b1a
1 parent 8d61c58
commit da42b1a
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 11 deletions.
diff --git a/management-api-server/doc/openapi.json b/management-api-server/doc/openapi.json
@@ -2137,9 +2137,6 @@
           "keyspace" : {
             "type" : "string"
           },
-          "notifications" : {
-            "type" : "boolean"
-          },
           "repair_parallelism" : {
             "type" : "string",
             "enum" : [ "sequential", "parallel", "dc_parallel" ]

diff --git a/management-api-server/src/main/java/com/datastax/mgmtapi/resources/v2/RepairResourcesV2.java b/management-api-server/src/main/java/com/datastax/mgmtapi/resources/v2/RepairResourcesV2.java
@@ -83,7 +83,7 @@ public final Response repair(RepairRequest request) {
                   request.keyspace,
                   request.tables,
                   request.fullRepair,
-                  request.notifications,
+                  true,
                   getParallelismName(request.repairParallelism),
                   request.datacenters,
                   getRingRangeString(request.associatedTokens),

diff --git a/...ment-api-server/src/main/java/com/datastax/mgmtapi/resources/v2/models/RepairRequest.java b/...ment-api-server/src/main/java/com/datastax/mgmtapi/resources/v2/models/RepairRequest.java
@@ -23,9 +23,6 @@ public class RepairRequest {
   @JsonProperty(value = "full_repair", defaultValue = "true")
   public final Boolean fullRepair;
 
-  @JsonProperty(value = "notifications", defaultValue = "true")
-  public final Boolean notifications;
-
   @Nullable
   @JsonProperty(value = "associated_tokens")
   public final List<RingRange> associatedTokens;
@@ -47,15 +44,13 @@ public RepairRequest(
       @JsonProperty(value = "keyspace", required = true) String keyspace,
       @JsonProperty(value = "tables") List<String> tables,
       @JsonProperty(value = "full_repair", defaultValue = "true") Boolean fullRepair,
-      @JsonProperty(value = "notifications", defaultValue = "true") boolean notifications,
       @JsonProperty(value = "associated_tokens") List<RingRange> associatedTokens,
       @JsonProperty(value = "repair_parallelism") RepairParallelism repairParallelism,
       @JsonProperty(value = "datacenters") List<String> datacenters,
       @JsonProperty(value = "repair_thread_count") Integer repairThreadCount) {
     this.keyspace = keyspace;
     this.tables = tables;
     this.fullRepair = fullRepair;
-    this.notifications = notifications;
     this.associatedTokens = associatedTokens;
     this.datacenters = datacenters;
     this.repairParallelism = repairParallelism;

diff --git a/...ent-api-server/src/test/java/com/datastax/mgmtapi/resources/v2/RepairResourcesV2Test.java b/...ent-api-server/src/test/java/com/datastax/mgmtapi/resources/v2/RepairResourcesV2Test.java
@@ -50,7 +50,6 @@ public void testRepairResourcesSuccess() throws Exception {
             "keyspace",
             Collections.singletonList("table1"),
             false,
-            true,
             Collections.singletonList(new RingRange("-100", "100")),
             RepairParallelism.DATACENTER_AWARE,
             Collections.EMPTY_LIST,
@@ -93,7 +92,6 @@ public void testRepairResourcesFail() throws Exception {
             "",
             tables,
             false,
-            true,
             Collections.EMPTY_LIST,
             RepairParallelism.DATACENTER_AWARE,
             Collections.EMPTY_LIST,