Server in URL not being set

[whosgonna]

When running:

#!/usr/bin/env perl
use WebService::DNSMadeEasy;

my $dns = WebService::DNSMadeEasy->new({
        api_key => $my_api_key,
        secret  => $my_secret,
        sandbox => 1,     # defaults to 0
});

my @domains = $dns->managed_domains;

I get the following failure:

"Cannot parse URL: '/dns/managed'
"
HTTP request failed
Request:  GET /dns/managed
Response: 599 Internal Exception
Cannot parse URL: '/dns/managed'

It looks like the issue is that the override of the server attribute in WebService/DNSMadeEasy/Client.pm is not executing it's builder. I'm not sure why this is, and i tried disabling lazy, and explicitly referencing the builder (builder = _build_server), but no luck with these.

I was able to get it to work by using a default instead, changing the line

has '+server'         => (builder => 1, lazy => 1);

in Client.pm to the following:

has '+server'         => (default => sub {
    my $self = shift;
    return _build_server($self);
});

If you're ok with this as a fix, I can submit a PR, however it might make more sense to re-name the _build_server subroutine since it's not technically the builder for the attribute any more. Alternately, the ternary condition to return the sandbox vs. live URL could just be put into the subroutine for the default.

[kablamo]

Thanks for this. Maybe put the ternary into the default? I'lll merge whatever you think is best and works. :)