Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve and generate as one command #193

Merged
merged 21 commits into from
May 2, 2023
Merged

Retrieve and generate as one command #193

merged 21 commits into from
May 2, 2023

Conversation

ash-vd
Copy link
Contributor

@ash-vd ash-vd commented Mar 27, 2023 •
edited by LindaOrtega
Loading

Reason:

With these changes it's possible to retrieve a contract from chain by using the --contract option for the generate command from pact-cli.

Closes #173

@ash-vd ash-vd force-pushed the feat/173-retrieve-and-generate-as-one-command branch 3 times, most recently from 0f7b0fe to f6e3270 Compare March 27, 2023 14:37
@ash-vd ash-vd requested a review from alber70g March 29, 2023 08:09
@ash-vd ash-vd force-pushed the feat/173-retrieve-and-generate-as-one-command branch from fe0744d to 117ce70 Compare March 31, 2023 14:42
@ash-vd
Copy link
Contributor Author

ash-vd commented Apr 3, 2023 •
edited
Loading

The tests in this PR aren't the prettiest they could be. I've created an issue to create a test-utils library (#197) which we can use to write better and easier to read tests.

Refactored, much better now

@ash-vd ash-vd force-pushed the feat/173-retrieve-and-generate-as-one-command branch from a655ce0 to 9e0574d Compare April 3, 2023 14:00
alber70g
alber70g previously requested changes Apr 5, 2023
View reviewed changes
packages/tools/pactjs-cli/src/retrieve-contract/index.ts Outdated Show resolved Hide resolved
@Randynamic
Copy link
Contributor

@all-contributors please add @ash-vd for Code

@allcontributors allcontributors bot mentioned this pull request Apr 5, 2023
Merged
@allcontributors
Copy link
Contributor

@Randynamic

I've put up a pull request to add @ash-vd! 🎉

@kadena-community kadena-community deleted a comment from allcontributors bot Apr 5, 2023
@Randynamic
Copy link
Contributor

@all-contributors please add @alber70g for review

@allcontributors allcontributors bot mentioned this pull request Apr 5, 2023
Merged
@allcontributors
Copy link
Contributor

@Randynamic

I've put up a pull request to add @alber70g! 🎉

@ash-vd ash-vd force-pushed the feat/173-retrieve-and-generate-as-one-command branch 3 times, most recently from eddf49b to db644bb Compare April 25, 2023 09:28
@ash-vd ash-vd requested review from EnoF and Takadenoshi April 26, 2023 13:10
@ash-vd ash-vd force-pushed the feat/173-retrieve-and-generate-as-one-command branch from 65e8e69 to fe0fea8 Compare May 2, 2023 11:06
@ash-vd ash-vd merged commit 43d80d3 into master May 2, 2023
@ash-vd ash-vd deleted the feat/173-retrieve-and-generate-as-one-command branch May 2, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaozler isaozler isaozler approved these changes

@Randynamic Randynamic Randynamic approved these changes

@alber70g alber70g alber70g left review comments

@EnoF EnoF Awaiting requested review from EnoF

@Takadenoshi Takadenoshi Awaiting requested review from Takadenoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@kadena/pactjs-cli] allow the user to retrieve and generate in one command
6 participants
@ash-vd @Randynamic @alber70g @isaozler @EnoF @Takadenoshi