[@kadena/Chainweb-stream-client] Receive heights event, improve reconnection strategy #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…am-receive-heights-event
Takadenoshi
requested review from
alber70g,
Randynamic and
ggobugi27
as code owners
alber70g
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements consumption of the heights event. Needed for the reconnection improvements #275 (comment). Server kadena-io/chainweb-stream#5
This changes the .lastHeight client property to track the highest block seen across all chains based on the server's corresponding cw-node. The reconnection property minheight is now sent as .lastHeight - CONFIRMATION_DEPTH - 3 (max chain height span)
Raising against a new base branch, as the upcoming release will require a deduplication module to only emit each event once. This will be raised separately against the same base branch