-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Batch highlightining #60
Draft
Sobak
wants to merge
15
commits into
feature/lang-dockerfile
Choose a base branch
from
feature/lang-batch
base: feature/lang-dockerfile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops us from improperly marking keywords inside strings
I don't even know what that is xD but it was carried over from Shell and it's clearly unused so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one big of a
messdraft. It's based off a #56 and obviously it will have to be rebased but for now I kept the somehow-original commit history to make it easier to understand thepainprocess I was going through.Open questions
%foo%
and%foo
- I have created two regex-based rules to match these. However, no matter how I set their priorities,%foo%
always gets matched as "comment %foo" and then "comment %" (even though I use\w+
). This can be seen in the token dump ofsmall.bat
or with the debug formatterdelimiter
rule used in Shell highlighting for?bit.batch
. This one really puzzles me tbh oO it can be seen from the token dump but lemme attach a screenshot to make it even more obviouspls send help