No expire, no cache limit.

[jamesgibson14]

Gives an option for no cache limit and no expire time by setting each option to 0.

[arunoda]

This is great.
Could you write some test cases?

I hope if these limits are zero, subsmanager assigns default values.
Can you please check that.

[jamesgibson14]

Sure, I am not great at tests but it is a good time to start learning I guess.

[arunoda]

Yeah! I hope so :)

On Tue Dec 09 2014 at 8:52:46 PM James [email protected] wrote:

Sure, I am not great at tests but it is a good time to start learning I
guess.

—
Reply to this email directly or view it on GitHub
#21 (comment)
.

[ccorcos]

was this never merged?

[jamesgibson14]

No I still need to push up some changes I have added, but I got sidetracked.

On Tue, Mar 10, 2015 at 2:42 PM, Chet Corcos [email protected]
wrote:

was this never merged?

—
Reply to this email directly or view it on GitHub
#21 (comment)
.

[ccorcos]

ok

[arunoda]

You may also need to rebase from the current master. I've added some core changes in the meantime.

[ccorcos]

I literally JUST did this. haha

[arunoda]

@ccorcos If so, send me a PR with tests :)

[ccorcos]

oh wait, I'm confusing this thread with subs-manager, no flow-router! ugh ;)

[jamesgibson14]

@arunoda Okay I wrote some tests and have rebased, so it should be good to merge in once you have a look at it.

[talha-asad]

Is this being worked on?