Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase package compatibility #12

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rubenvandeven
Copy link

Hi Kadirnar,
Thanks for implementing this tracker. Based on work in other forks, I made some changes to the package:

  • Remove Pytorch dependency (this was done in a fork by @0xNOY)
  • Changed the dependency on lap to lapx to have compatibility with python >= 3.10 (following the example of forks by @gimletlabs and @TomDarmon )
  • Relaxed the dependence to improve package resolution in a larger project.
  • I ran into an exception in update() when dets is an empy array/tensor.
  • Fix issue A bug about initializing STrack bbox #2 by adding an xyxy2ltwh() function.

It would be nice to see these revisions upstreamed. Feel free to cherrypick.

@kadirnar
Copy link
Owner

I can't test it because I'm very busy. Did you test it?

@rubenvandeven
Copy link
Author

Understandable! I do use this repo in my own code, so yes I did.
Important to note however that due to fixing #2 the coordinates are different that the original repo, in which the resulting bboxes were misaligned (the top left corner was at the detection's center). If one relies on exact position, that this can be considered a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants