Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to footer layout #84

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fixes to footer layout #84

merged 2 commits into from
Jul 1, 2024

Conversation

edward-ly
Copy link
Contributor

Just discovered this theme and it has to be my new favorite! Although, the footer had two small issues which I was able to fix here:

  1. the spacing between the short subtitle and author name was not consistent, and
  2. the footer with the nofooterlogo option was not updated to use the same short text layout as the one without.
  • Followed the Contributing guide
  • Read the PR guide
  • Referenced relevant issues, if applicable: (none)
  • If necessary, I have updated the documentation.

Copy link

welcome bot commented Jun 18, 2024

Thanks for opening this pull request! 💖
Please check out the code of conduct and the contributing guidelines.
Although, you probably have read it already. 😎

@kai-tub
Copy link
Owner

kai-tub commented Jul 1, 2024

Hey, thanks for the contribution!

Sorry for the delay 🙏
The CI pipeline + developer environment was quite rusty, and I took this PR as a motivation to make some internal upgrades.

Thanks again!
(The images will be updated shortly)

@kai-tub kai-tub merged commit cd35d7a into kai-tub:master Jul 1, 2024
2 checks passed
Copy link

welcome bot commented Jul 1, 2024

Congrats on merging your first pull request! 🎉🎉🎉
We are proud of you and your accomplishment 🏆.

thanks-for-pr-image

@edward-ly edward-ly deleted the fix/footer-layout branch July 4, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants