Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding spinkube #115

Merged
merged 1 commit into from
Dec 4, 2024
Merged

adding spinkube #115

merged 1 commit into from
Dec 4, 2024

Conversation

asteurer
Copy link
Contributor

@asteurer asteurer commented Dec 3, 2024

@asteurer
Copy link
Contributor Author

asteurer commented Dec 4, 2024

Distros Tested

Success

  • Ubuntu 24.04
  • Fedora 40
  • Rocky 9
  • OpenSuse Tumbleweed
  • OpenSuse Leap 15.6
  • Debian Bookworm

Fail

  • Alpine 3.19 (needs systemd)

How they were tested

  • The bundles were installed using this command:

    ssh kairos@$(IP_ADDR) 'sudo kairos-agent install-bundle run://ghcr.io/asteurer/kairos-wasm-bundle:0.0.0'
  • The configuration succeeded if the following were true:

    • kubeconfig apply -f spin.yaml (see code block below) resulted in a running spin-app pod.

    • kubectl port-forward svc spin-app 8080:80 didn't result in errors.

    • curl localhost:8080 returned "Hello Fermyon!".

      apiVersion: core.spinkube.dev/v1alpha1
      kind: SpinApp
      metadata:
        name: spin-app
      spec:
        image: "ghcr.io/spinkube/spin-operator/hello-world:20241125-155422-g07a3175"
        replicas: 1
        executor: containerd-shim-spin
      

Signed-off-by: Andrew Steurer <[email protected]>

asdf

Signed-off-by: Andrew Steurer <[email protected]>
@asteurer asteurer marked this pull request as ready for review December 4, 2024 01:35
@mauromorales mauromorales self-requested a review December 4, 2024 08:15
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@mauromorales mauromorales merged commit 0572584 into kairos-io:main Dec 4, 2024
16 checks passed
@Itxaka Itxaka requested a review from Copilot December 4, 2024 08:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • spinkube/Dockerfile: Language not supported
  • spinkube/run.sh: Language not supported
@Itxaka
Copy link
Member

Itxaka commented Dec 4, 2024

uh, I wonder why this wont work with alpine. I know no systemd but doesnt this runs under k8s itself, nothing really on the node?

@asteurer
Copy link
Contributor Author

asteurer commented Dec 4, 2024

@Itxaka It has to do with the Kwasm installer calling systemctl directly: https://github.com/search?q=repo%3AKWasm%2Fkwasm-node-installer%20systemctl&type=code

@asteurer asteurer deleted the spinkube branch December 4, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🌱 Bundle: WASM
3 participants