isTextChange should compare between this.state.text with this.props.text #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… props, it should be changed to a text that we passed. (even if it's same as previous text) So isTextChange should compare between this.state.text with this.props.text.
… called when a user starts and finishes editing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user's already changed text then we pass text to this class as props, it should be changed to a text that we passed. (even if it's same as previous text)
So isTextChange should compare between this.state.text with this.props.text.
And also we should able to pass functions onStartEditing and onFinishEditing as props to be
called when a user starts and finishes editing.
That makes we can do something, when we click away from the text area. (issue #28)