전남대 Android_오진우_4주차 과제_Step1 #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigstark
approved these changes
Jul 21, 2024
| bottomSheetBehavior.state = BottomSheetBehavior.STATE_HIDDEN | ||
| } | ||
|
|
||
| private fun initSDK() { |
There was a problem hiding this comment.
저번에 코멘트를 드리지 못한 부분이긴한데, sdk 의 initialize 는 activity 에서 하기보다 Application 에서 처리하기를 권장하고 있습니다! (kakao map 도 마찬가지네요!)
Comment on lines
138
to
139
| val latitude = place?.y?.toDouble() ?: 127.115587 | ||
| val longitude = place?.x?.toDouble()?: 37.406960 |
There was a problem hiding this comment.
127.127.115587, 37.406960 이 무슨 좌표값인지 정확히 표시해주는 것이 좋습니다. companion object 등을 통해 const 로 정의해주세요!
|
|
||
| private fun getErrorMessage(errorText: String): String { | ||
| val errorCode = getErrorCode(errorText) | ||
| // enum으로 처리? |
Comment on lines
225
to
229
| private fun putPosSharedPreference(latitude : Double, longitude : Double){ | ||
| editor.putString(Constants.Keys.KEY_LATITUDE, latitude.toString()) | ||
| editor.putString(Constants.Keys.KEY_LONGITUDE, longitude.toString()) | ||
| editor.apply() | ||
| } |
There was a problem hiding this comment.
이런 로직이 Activity 에 있는 것이 좋은 구조는 아닙니다. 이런 로직을 처리하는 Repository 를 만들고, ViewModel 을 통해서 처리해주시면 좋을 것 같아요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
오늘도 코드리뷰 부탁드립니다!
코드 작성하면서 어려웠던 점 & 느낀 점
멘토님께서 중점적으로 리뷰해주셨으면 하는 부분
실행 모습
목록을 클릭하면 위치로 이동
https://github.com/user-attachments/assets/1fd98007-ed28-424c-9d36-0aa122e1fc9d
다시 실행하면 가장 최근 위치를 띄우기
https://github.com/user-attachments/assets/330e4618-2804-4e4f-94fa-675dba0675e9
맵 error 화면
언제나 감사드립니다!