부산대 Android_노신 4주차 Step2 #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeOhHyung
reviewed
Jul 21, 2024
Comment on lines
21
to
23
| if (savedInstanceState == null) { | ||
| showMapFragment() | ||
| } |
There was a problem hiding this comment.
savedInstanceState가 없을때만 map fragment를 보여주게 한 이유가 있으신가요? 혹시, 화면회전이나 구성요소변경 상황을 대응하려고 하셨던것일까요?
Comment on lines
96
to
118
| fun searchPlaces(query: String) { | ||
| val apiKey = "KakaoAK ${campus.tech.kakao.map.BuildConfig.KAKAO_REST_API_KEY}" | ||
|
|
||
| RetrofitClient.instance.searchPlaces(apiKey, query).enqueue(object : Callback<ResultSearchKeyword> { | ||
| override fun onResponse(call: Call<ResultSearchKeyword>, response: Response<ResultSearchKeyword>) { | ||
| if (response.isSuccessful && response.body() != null) { | ||
| val places = response.body()?.documents ?: emptyList() | ||
| if (places.isEmpty()) { | ||
| showNoResultMessage() | ||
| } else { | ||
| hideNoResultMessage() | ||
| adapter.updateData(places) | ||
| } | ||
| } else { | ||
| showNoResultMessage() | ||
| } | ||
| } | ||
|
|
||
| override fun onFailure(call: Call<ResultSearchKeyword>, t: Throwable) { | ||
| showNoResultMessage() | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
이 부분은 카카오api를 통해서 장소검색을 수행하는곳 이네요. UI표현, 데이터 조회를 모두 fragment에서 하기 보다는 data를 가져오는곳을 repository로 분리하는것이 좋을것 같습니다. UI 입장에서 어디에서 데이터를 가져오는지 까지 담당할 필요는 없기 때문이죠. 조회가 완료된 형태의 places데이터만 전달받는게 어떨까 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어려웠던 점
멘토님에게 말씀드린 에러 처리를 못했습니다. 코드리뷰후 수정을 거치겠습니다
중점적으로 리뷰해주셨으면 하는 부분
없습니다.