전남대 Android_장수민_5주차 과제(Step1) #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omjoonkim
approved these changes
Jul 28, 2024
| private val preferenceManager: PreferenceManager | ||
| @HiltViewModel | ||
| class MainViewModel @Inject constructor( | ||
| private val context: Context, |
There was a problem hiding this comment.
context를 사용하는 부분이 없어 보이는데, 제거해도 괜찮지 않을까요?
|
|
||
| @Provides | ||
| @Singleton | ||
| fun provideContext(application: Application): Context { |
There was a problem hiding this comment.
nit; 의존성 주입을 받는쪽에서 ApplicationContext 어노테이션을 사용하면, 이런 Provide 함수를 제거 할 수 있습니다.
|
5주차 과제는 전반적으로 잘해주신 것 같습니다~!. 고생하셨어요.
모든 곳을 Room으로 변경해보세요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5주차 과제
1단계
기능 사항
💀어려웠던 부분
1단계에서 Room으로 데이터베이스를 변경하라고 되어있는데, 검색어 저장 부분을 변경하면 되는지, 아니면 (지금은 사용하지 않는)2주차에서 SQLite로 구현한 장소 DB를 Room을 사용하는 것으로 바꾸어야 하는지 궁금합니다. 어디를 바꿔야할지 모르겠어서 아직 바꾸지 않았습니다...🥲
의존성 주입을 맞게 한 것인지, 필요한 부분이 더 있는지 궁금합니다.
📷앱 사진(저번 과제와 비교했을 때 UI적으로 달라진 부분은 없습니다!!)
항상 코드리뷰 해주셔서 감사합니다!!