충남대 Android_김선규 5주차 Step3 #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omjoonkim
approved these changes
Jul 28, 2024
|
|
||
| @Provides | ||
| @Singleton | ||
| fun provideSavedSearchKeywordRepository(@ApplicationContext context: Context): SavedSearchKeywordRepository { |
There was a problem hiding this comment.
테스트 작성 관점에서 안드로이드등의 플랫폼이나, 파이어베이스 같은 라이브러리를 직접 주입받는 것은 지양하는 것이 좋습니다.
꼭 필요하다면 컨텍스트가 필요한 로직을 한번 감싸서 인터페이스를 주입받도록 만드는 것이 좋아요.
There was a problem hiding this comment.
해당 피드백에 대해 잘 이해가 되지 않습니다.
Provide 함수의 인자로 외부 라이브러리들이 오면 안 된다는 걸로 이해하면 되는지 궁금합니다.
혹시 예시 코드나 정리된 사이트 같은 게 있는지 궁금합니다.
app/src/main/java/campus/tech/kakao/map/repository/search/SavedSearchKeywordRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/campus/tech/kakao/map/repository/search/SearchRepository.kt
Outdated
Show resolved
Hide resolved
|
피드백 해주신 부분에 대해 수정했습니다. |
* Initial commit * Merge : android-map-keyword into android-map-search (kakao-tech-campus-2nd-step2#8) * 충남대 Android_김선규 3주차 과제 Step1 (kakao-tech-campus-2nd-step2#47) * docs: add step1 requirements * chore: set for using android api * style: rename id in layout * feat: remove storeInfo for using api * feat: add connecting api for searching * style: rename variable name proper * 충남대 Android_김선규 3주차 과제 Step2 (kakao-tech-campus-2nd-step2#85) * style: function rename and split * feat: Change function to fit coroutine * docs: add step2 requirements * style: move from main to sub file * chore: set it up to work in the right environment * feat: display kakao map, when app is started --------- Co-authored-by: MyStoryG <[email protected]>
* docs: add week 4 step 1 requirements * feat: add searching by saved search keyword * chore: relocate files proper * feat: modify adapter to make clean code * feat: add image for marker * feat: add layout for displaying bottom sheet * feat: add parcelabel for easy to send data * feat: add displaying search result * refactor: modify class structure * feat: add error screen and reload button * feat: add saving and loading last position when app is closed, save last position when app is opened, load last position
* style: rename variable name * feat: add viewModel and Repository for saving last position * refactor: classify in more detail * test: add android UI test * chore: add mockk test dependency * test: add ViewModel test * chore: add testOptions * test: modify android ui test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 3
코드 작성하면서 어려웠던 점
코드 리뷰 시, 멘토님이 중점적으로 리뷰해줬으면 하는 부분