경북대 Android 남지연 5주차 과제 Step2 #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
리베이스 부탁드려요 ~ |
mkSpace
approved these changes
Jul 28, 2024
| @@ -4,4 +4,4 @@ import campus.tech.kakao.map.model.Item | |||
|
|
|||
| interface OnSearchItemClickListener { | |||
| fun onSearchItemClick(item: Item) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
ViewModel에 리스너가 있는건 어색하네요. View로 옮겨주세요
| import campus.tech.kakao.map.repository.keyword.KeywordDao | ||
| import campus.tech.kakao.map.repository.location.ItemDao | ||
|
|
||
| @Database(entities = [Keyword::class, Item::class], version = 1) | ||
| @Database(entities = [KeywordEntity::class, LocationEntity::class], version = 2) |
There was a problem hiding this comment.
Item -> LocationEntity로 변경하셨으니 ItemDao도 그에 맞게 변경하면 좋겠네요
Comment on lines
+7
to
+8
| @Singleton | ||
| class KeywordRepository @Inject constructor(private val keywordDao: KeywordDao) { |
There was a problem hiding this comment.
DatabaseModule에서도 KeywordRepsoitroy 의존성을 생성하고 여기서도 생성하시는 이유가 있을까요?
특별한 이유가 없으면 하나의 방법으로 통일시키는게 좋겠습니다.
There was a problem hiding this comment.
DatabaseModule에서만 생성하도록 수정하였습니다 !
| @@ -24,6 +24,10 @@ import javax.inject.Inject | |||
| @AndroidEntryPoint | |||
| class SearchActivity : AppCompatActivity(), OnSearchItemClickListener, OnKeywordItemClickListener { | |||
| private lateinit var binding: ActivitySearchBinding | |||
|
|
|||
| @Inject | |||
| lateinit var api: KakaoLocalApi | |||
There was a problem hiding this comment.
Viewmodel에서 처리를 하고 있으므로 따로 주입받을 필요가 없습니다 ! 해당 부분을 삭제하도록 하겠습니다 !
Comment on lines
31
to
32
| private lateinit var searchViewModel: SearchViewModel | ||
| private lateinit var keywordViewModel: KeywordViewModel |
There was a problem hiding this comment.
ViewModel를 by viewModels 를 통해 ViewModel을 LAZY 하게 providing 받을 수 있는 기능을 제공합니다. 한 번 적용해보세요!
|
혹시 코루틴 적으로 레벨업 하시려면 Flow를 최대한 사용해보시면 좋을 것 같네요! |
…wordDbHelper.kt Delete KeywordDbHelper
…wordContract.kt Delete KeywordContract
…cationDbHelper.kt delete LocationDbHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
중점적으로 리뷰해주셨으면 하는 부분
데이터바인딩과코루틴을 적용할 수 있는 부분에 최대한 적용하였다고 생각했는데, 혹시 부족한 부분이나 추가적으로 적용할 수 있는 부분이 있는지 궁금합니다 !