전남대 FE_이도현 6주차 과제 #111
Open
전남대 FE_이도현 6주차 과제 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlsehdfl
reviewed
Aug 6, 2024
| }, | ||
| }); | ||
|
|
||
| instance.interceptors.request.use((config) => { |
There was a problem hiding this comment.
interceptor 선언을 해당 훅에 선언한 이유가 있나요 ? 공통으로 적용되는 부분이기 때문에 api/index.ts 같은 곳에 선언하면 될 거 같아요.
|
|
||
| export type GoodsDetailResponseData = ProductData; | ||
|
|
||
| export const getProductDetailPath = (productId: string) => `${BASE_URL}/api/products/${productId}`; |
There was a problem hiding this comment.
baseUrl 을 axios instance 에 공통으로 선언하면 base url 을 한 곳에서만 선언하면 됩니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6주차 과제 제출합니다..