경북대 BE_권도윤_1주차 과제(1~3단계) #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangKyu
requested changes
Jun 29, 2024
| # spring-gift-product | ||
| - [x] 상품을 조회, 추가, 수정, 삭제할 수 있는 HTTP API를 구현한다. |
| @@ -2,10 +2,13 @@ | |||
|
|
|||
| import org.springframework.boot.SpringApplication; | |||
| import org.springframework.boot.autoconfigure.SpringBootApplication; | |||
| import org.springframework.context.annotation.Bean; | |||
| import org.springframework.web.filter.HiddenHttpMethodFilter; | |||
| package gift; | ||
|
|
||
| public class Product { | ||
| Long id; |
There was a problem hiding this comment.
private과 같은 적절한 접근제어자를 사용하면 접근을 제한할 수 있습니다ㅎㅎ
자바가 제공하는 접근제어자에 대해서도 알아보시면 좋을 것 같아요!
Suggested change
| Long id; | |
| private Long id; |
|
|
||
| } | ||
|
|
||
| public Product(Long id, String name, int price, String imageUrl){ |
| id BIGINT AUTO_INCREMENT PRIMARY KEY, | ||
| name VARCHAR(255) NOT NULL, | ||
| price DECIMAL(10, 2) NOT NULL, | ||
| image_url VARCHAR(255) |
There was a problem hiding this comment.
image url이 null이 될 수 없다면, 해당 부분에도 not-null 제약 조건을 걸어주는 것이 좋을 것 같습니다ㅎㅎ
| return "redirect:/"; | ||
| } | ||
|
|
||
| @PostMapping ("/update") |
There was a problem hiding this comment.
수정을 위한 HTTP Method로는 PUT, PATCH 그리고 삭제를 위해서는 DELETE가 존재합니다.
따라서 용도에 맞는 HTTP Method를 활용하는 것이 바람직할 것 같습니다ㅎㅎ
There was a problem hiding this comment.
그리고 API 요청의 prefix로 /products 와 같이 구분을 두면 좋을 것 같습니다!
이후에 상품 외에 다른 추가/삭제/수정 요청이 생기면 문제가 생길 수 있습니다ㅎㅎ
| @Autowired | ||
| public ProductRepository(JdbcTemplate jdbcTemplate, DataSource dataSource) { | ||
| this.jdbcTemplate = jdbcTemplate; | ||
| this.insertProduct = new SimpleJdbcInsert(dataSource) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.