hotfix

buffalo/algo/als.py

@@ -43,7 +43,6 @@ def __init__(self, opt_path=None, *args, **kwargs):
         self.obj = CuALS() if self.opt.accelerator else CyALS()
         assert self.obj.init(bytes(self.opt_path, 'utf-8')),\
             'cannot parse option file: %s' % opt_path
-        self.vdim = self.obj.get_vdim() if self.opt.accelerator else self.opt.d
         self.data = None
         data = kwargs.get('data')
         data_opt = self.opt.get('data_opt')
@@ -75,6 +74,7 @@ def normalize(self, group='item'):
             self.opt._nrz_P = True
 
     def initialize(self):
+        self.vdim = self.obj.get_vdim() if self.opt.accelerator else self.opt.d
         super().initialize()
         self.init_factors()
 

buffalo/algo/base.py

@@ -207,7 +207,7 @@ def periodical(self, period, current):
 
     def save_best_only(self, loss, best_loss, i):
         if self.opt.save_best and best_loss > loss and self.periodical(self.opt.save_period, i):
-            self.save(self.model_path)
+            self.save(self.opt.model_path)
             return loss
         return best_loss