-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(client): use transmitResultPool to reduce heap allocs #722
Draft
ijsong
wants to merge
1
commit into
main
Choose a base branch
from
perf_transmitResultPool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2024
d406846
to
b6f2ad1
Compare
b2ae65b
to
a79d3c1
Compare
b6f2ad1
to
f4ffd0c
Compare
a79d3c1
to
d04339e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
==========================================
- Coverage 49.72% 49.63% -0.10%
==========================================
Files 235 235
Lines 20725 20731 +6
==========================================
- Hits 10305 10289 -16
- Misses 9780 9797 +17
- Partials 640 645 +5 ☔ View full report in Codecov by Sentry. |
f4ffd0c
to
e44af3d
Compare
d04339e
to
1dd22e8
Compare
e44af3d
to
43cbfbf
Compare
1dd22e8
to
eb3c73f
Compare
43cbfbf
to
dc0cc0d
Compare
eb3c73f
to
ceab392
Compare
dc0cc0d
to
c3d0003
Compare
ceab392
to
53481ef
Compare
c3d0003
to
ab52113
Compare
53481ef
to
fd0898a
Compare
ab52113
to
1e93669
Compare
fd0898a
to
728cdc3
Compare
728cdc3
to
7219cc8
Compare
7219cc8
to
aa40aec
Compare
Struct pkg/varlog.(transmitResult) is an element of transmitQueue. It is allocated in heap memory to be pushed into transmitQueue. This PR introduces transmitResultPool to reuse transmitResult as possible.
aa40aec
to
94fad3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP