Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sn): add metrics for Append and Replicate RPCs #806

Merged
merged 1 commit into from
Jun 15, 2024

feat(sn): add metrics for Append and Replicate RPCs

d52ff1d
Select commit
Loading
Failed to load commit list.
Merged

feat(sn): add metrics for Append and Replicate RPCs #806

feat(sn): add metrics for Append and Replicate RPCs
d52ff1d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 13, 2024 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 88.99083% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (dockerfile_grpc_health_probe@5aae6ec). Learn more about missing BASE report.

Files Patch % Lines
internal/storagenode/telemetry/metrics.go 88.63% 5 Missing and 5 partials ⚠️
internal/storagenode/logstream/append.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##             dockerfile_grpc_health_probe     #806   +/-   ##
===============================================================
  Coverage                                ?   68.46%           
===============================================================
  Files                                   ?      182           
  Lines                                   ?    17899           
  Branches                                ?        0           
===============================================================
  Hits                                    ?    12255           
  Misses                                  ?     4859           
  Partials                                ?      785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.