feat(logstream): deprecate error field in AppendResult for atomic append #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 79.91% 80.07% +0.16%
==========================================
Files 178 178
Lines 21408 21412 +4
==========================================
+ Hits 17108 17146 +38
+ Misses 3504 3485 -19
+ Partials 796 781 -15 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
commit_wait_task_for_append_batch
branch
from
64e44ac to
bd370e3
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
5a03f0d to
0afc4ab
Compare
ijsong
force-pushed
the
commit_wait_task_for_append_batch
branch
from
bd370e3 to
fdd3cd2
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
0afc4ab to
4511a81
Compare
ijsong
force-pushed
the
commit_wait_task_for_append_batch
branch
from
fdd3cd2 to
3785ebc
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
4511a81 to
f172616
Compare
ijsong
force-pushed
the
commit_wait_task_for_append_batch
branch
from
3785ebc to
218206a
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
f172616 to
c119d34
Compare
ijsong
force-pushed
the
commit_wait_task_for_append_batch
branch
from
218206a to
be0ae21
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
c119d34 to
b3d4566
Compare
ijsong
force-pushed
the
commit_wait_task_for_append_batch
branch
from
be0ae21 to
7bbd20c
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
b3d4566 to
0515210
Compare
ijsong
force-pushed
the
commit_wait_task_for_append_batch
branch
from
7bbd20c to
38bffc0
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
0515210 to
b8ded9d
Compare
This commit deprecates the error field in AppendResult as a step towards implementing atomic append operations while maintaining backward compatibility. Previously, the Append RPC could return partial success/failure results, with some log entries in a batch being appended successfully and others failing. This was indicated by the error field in AppendResult. To support atomic append operations without breaking existing clients, the error field is deprecated instead of being removed completely. This change allows clients to continue using the error field for now, but they should be aware that it will be removed in a future release. Clients should start migrating to the new atomic append API as soon as possible. The following changes were made to deprecate the error field: - The error field in AppendResult is marked as deprecated in the protobuf definition. - The Append RPC implementation no longer populates the error field. The next step is to implement atomic append operations in the client API. This will enable clients to append multiple log entries atomically, which will help to resolve #843.
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
b8ded9d to
48dd48a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This commit deprecates the error field in AppendResult as a step towards
implementing atomic append operations while maintaining backward compatibility.
Previously, the Append RPC could return partial success/failure results, with
some log entries in a batch being appended successfully and others failing. This
was indicated by the error field in AppendResult.
To support atomic append operations without breaking existing clients, the error
field is deprecated instead of being removed completely. This change allows
clients to continue using the error field for now, but they should be aware that
it will be removed in a future release. Clients should start migrating to the
new atomic append API as soon as possible.
The following changes were made to deprecate the error field:
definition.
The next step is to implement atomic append operations in the client API. This
will enable clients to append multiple log entries atomically, which will help
to resolve #843.