refactor(logstream): consolidate append wait groups into a single object #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
44d1fb0 to
3b5d0de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## deprecate_error_field_in_appendresult #995 +/- ##
=========================================================================
- Coverage 80.07% 80.02% -0.06%
=========================================================================
Files 178 178
Lines 21412 21402 -10
=========================================================================
- Hits 17146 17127 -19
+ Misses 3485 3484 -1
- Partials 781 791 +10 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
4511a81 to
f172616
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
3b5d0de to
1ad1abf
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
f172616 to
c119d34
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
1ad1abf to
44b49d5
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
c119d34 to
b3d4566
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
44b49d5 to
5f405f7
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
b3d4566 to
0515210
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
5f405f7 to
ed39e3b
Compare
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
0515210 to
b8ded9d
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
ed39e3b to
7b9ac3a
Compare
This PR reduces append wait groups to a single object for each append batch. The append wait groups are part of the following structs: - appendContext - commitWaitTask - sequenceTask Previously, multiple append wait groups existed because each log entry in a batch had its own wait group. With the changes for issue #843, a single append wait group now corresponds to an entire batch. This PR consolidates the list of append wait groups into a single append wait group. TODO: We are still on the road to resolving #843. The rest of the work mostly involves cleaning up the code base.
ijsong
force-pushed
the
deprecate_error_field_in_appendresult
branch
from
b8ded9d to
48dd48a
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
7b9ac3a to
a05f7e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR reduces append wait groups to a single object for each append batch. The
append wait groups are part of the following structs:
Previously, multiple append wait groups existed because each log entry in a
batch had its own wait group. With the changes for issue #843, a single append
wait group now corresponds to an entire batch. This PR consolidates the list of
append wait groups into a single append wait group.
TODO: We are still on the road to resolving #843. The rest of the work mostly
involves cleaning up the code base.