refactor: remove totalBytes field from appendContext #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## consolidate_append_wait_groups_into_a_single_object #996 +/- ##
=======================================================================================
+ Coverage 80.02% 80.08% +0.06%
=======================================================================================
Files 178 178
Lines 21402 21405 +3
=======================================================================================
+ Hits 17127 17143 +16
+ Misses 3484 3475 -9
+ Partials 791 787 -4 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
3b5d0de to
1ad1abf
Compare
ijsong
force-pushed
the
remove_totalbytes_field_from_appendcontext
branch
from
698ec10 to
f8f0f9a
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
1ad1abf to
44b49d5
Compare
ijsong
force-pushed
the
remove_totalbytes_field_from_appendcontext
branch
from
f8f0f9a to
3090904
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
44b49d5 to
5f405f7
Compare
ijsong
force-pushed
the
remove_totalbytes_field_from_appendcontext
branch
from
3090904 to
9dbf3f4
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
5f405f7 to
ed39e3b
Compare
ijsong
force-pushed
the
remove_totalbytes_field_from_appendcontext
branch
from
9dbf3f4 to
7e80e10
Compare
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
ed39e3b to
7b9ac3a
Compare
ijsong
force-pushed
the
remove_totalbytes_field_from_appendcontext
branch
from
7e80e10 to
34d085d
Compare
This PR removes the totalBytes field from the appendContext struct. It modifies prepareAppendContext to return totalBytes instead of changing the appendContext struct. Through this PR, the appendContext becomes slightly simple.
ijsong
force-pushed
the
consolidate_append_wait_groups_into_a_single_object
branch
from
7b9ac3a to
a05f7e3
Compare
ijsong
force-pushed
the
remove_totalbytes_field_from_appendcontext
branch
from
34d085d to
115ec16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the totalBytes field from the appendContext struct. It modifies
prepareAppendContext to return totalBytes instead of changing the appendContext
struct. Through this PR, the appendContext becomes slightly simple.