Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.6] Track xpadneo as in-kernel driver #29

Draft
wants to merge 6 commits into
base: base-6.6
Choose a base branch
from
Draft

[6.6] Track xpadneo as in-kernel driver #29

wants to merge 6 commits into from

Conversation

kakra
Copy link
Owner

@kakra kakra commented Nov 26, 2023 •
edited
Loading

Export patch series: https://github.com/kakra/linux/pull/28.patch

  • xpadneo in-kernel driver: devices handled by xpadneo will be automatically excluded from other kernel drivers (no udev magic or module blacklisting required), otherwise tracks a more or less stable status of the xpadneo development branch, also: if compiled as a module, update via native xpadneo repository is possible

atar-axis and others added 6 commits November 20, 2023 00:12
@atar-axis @kakra
xpadneo: Add hid-xpadneo v0.9.5
61f51ba 
Co-authored-by: Kai Krakow <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
@atar-axis @kakra
xpadneo: Exclude xpadneo devices from hid-generic
3579a91 
Added new Xpad driver to the list of specialized drivers, in order to
prevent hid-generic claiming Xbox One S devices.

Signed-off-by: Florian Dollinger <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
@kakra
xpadneo: Exclude xpadneo devices from hid-microsoft
6550330 
Remove Xbox One S device id from specialized microsoft driver in order to
prevent it from claiming the device.

Signed-off-by: Kai Krakow <[email protected]>
@atar-axis @kakra
Added hid-xpadneo to Makefile
02f2931 
Signed-off-by: Florian Dollinger <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
@atar-axis @kakra
Added hid-xpadneo to Kconfig (hid)
7ba9a87 
Signed-off-by: Florian Dollinger <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
@kakra
xpadneo: Merge upstream changes
72c00d1 
Signed-off-by: Kai Krakow <[email protected]>
@kakra kakra mentioned this pull request Nov 26, 2023
Closed
kakra pushed a commit that referenced this pull request Aug 4, 2024
@gregkh
selftests/bpf: Null checks for links in bpf_tcp_ca
691ec70 
[ Upstream commit eef0532 ]

Run bpf_tcp_ca selftests (./test_progs -t bpf_tcp_ca) on a Loongarch
platform, some "Segmentation fault" errors occur:

'''
 test_dctcp:PASS:bpf_dctcp__open_and_load 0 nsec
 test_dctcp:FAIL:bpf_map__attach_struct_ops unexpected error: -524
 #29/1    bpf_tcp_ca/dctcp:FAIL
 test_cubic:PASS:bpf_cubic__open_and_load 0 nsec
 test_cubic:FAIL:bpf_map__attach_struct_ops unexpected error: -524
 #29/2    bpf_tcp_ca/cubic:FAIL
 test_dctcp_fallback:PASS:dctcp_skel 0 nsec
 test_dctcp_fallback:PASS:bpf_dctcp__load 0 nsec
 test_dctcp_fallback:FAIL:dctcp link unexpected error: -524
 #29/4    bpf_tcp_ca/dctcp_fallback:FAIL
 test_write_sk_pacing:PASS:open_and_load 0 nsec
 test_write_sk_pacing:FAIL:attach_struct_ops unexpected error: -524
 #29/6    bpf_tcp_ca/write_sk_pacing:FAIL
 test_update_ca:PASS:open 0 nsec
 test_update_ca:FAIL:attach_struct_ops unexpected error: -524
 settcpca:FAIL:setsockopt unexpected setsockopt: \
					actual -1 == expected -1
 (network_helpers.c:99: errno: No such file or directory) \
					Failed to call post_socket_cb
 start_test:FAIL:start_server_str unexpected start_server_str: \
					actual -1 == expected -1
 test_update_ca:FAIL:ca1_ca1_cnt unexpected ca1_ca1_cnt: \
					actual 0 <= expected 0
 #29/9    bpf_tcp_ca/update_ca:FAIL
 #29      bpf_tcp_ca:FAIL
 Caught signal #11!
 Stack trace:
 ./test_progs(crash_handler+0x28)[0x5555567ed91c]
 linux-vdso.so.1(__vdso_rt_sigreturn+0x0)[0x7ffffee408b0]
 ./test_progs(bpf_link__update_map+0x80)[0x555556824a78]
 ./test_progs(+0x94d68)[0x5555564c4d68]
 ./test_progs(test_bpf_tcp_ca+0xe8)[0x5555564c6a88]
 ./test_progs(+0x3bde54)[0x5555567ede54]
 ./test_progs(main+0x61c)[0x5555567efd54]
 /usr/lib64/libc.so.6(+0x22208)[0x7ffff2aaa208]
 /usr/lib64/libc.so.6(__libc_start_main+0xac)[0x7ffff2aaa30c]
 ./test_progs(_start+0x48)[0x55555646bca8]
 Segmentation fault
'''

This is because BPF trampoline is not implemented on Loongarch yet,
"link" returned by bpf_map__attach_struct_ops() is NULL. test_progs
crashs when this NULL link passes to bpf_link__update_map(). This
patch adds NULL checks for all links in bpf_tcp_ca to fix these errors.
If "link" is NULL, goto the newly added label "out" to destroy the skel.

v2:
 - use "goto out" instead of "return" as Eduard suggested.

Fixes: 06da9f3 ("selftests/bpf: Test switching TCP Congestion Control algorithms.")
Signed-off-by: Geliang Tang <[email protected]>
Reviewed-by: Alan Maguire <[email protected]>
Link: https://lore.kernel.org/r/b4c841492bd4ed97964e4e61e92827ce51bf1dc9.1720615848.git.tanggeliang@kylinos.cn
Signed-off-by: Martin KaFai Lau <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakra @atar-axis