List possible variables, types, properties and imports when cannot find reference #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candidates for CouldNotFindType and CouldNotFindVariable errors
possible candidates with their error messages.
…so added partial_import_path to the CannotOpenFile struct as it will be needed to find candidates for the error message. Finally, added get_property_does_not_exist_message, a function that uses get_possibles_mesage to create a message for the PropertyDoesNotExist error based on the the type of the property.
get_property_as_string. These functions will be used to create a list of possible property names for the PropertyDoesNotExist error.
replacement when CannotOpenFile error is raised
…for" This reverts commit d8a5137. Removed get_all_imports_functions as it is not necessary
possibles and partial_import_path to CannotOpenFile.
to find possible candidates when the CannotOpenFile error is raised.
get_properties_on_single_type errors
vHugoObject
changed the title
|
Awesome! Thanks for the changes, all looks good. Especially for going the extra mile to add suggestions for properties and files. Clippy error seems to be caused by new Rust update, so will ignore for now. In the future may change the testing and diagnostics but won't fuss about that for now. |
kaleidawave
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #166. A get_closest function was added using the levenshtein crate. This function is used to create a list of possible variables, types, properties and imports when a cannot find reference error is raised. The specification tests have been updated to reflect the new error message. I would like to note that in the code, there are currently two functions that can be used to raise a cannot find reference error for properties: PropertyDoesNotExist and ExcessProperty. My pull request only makes changes to the PropertyDoesNotExist. ExcessProperty would need lifetime annotations for a "possibles" variables, which would have required a bigger revision of the TypeCheckWarning enum.