-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watch mode support #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't particularly want to do this, since it required changing the internal checker code, but it seemed like the only way to get it to work as ownership is passed to the checker when it's passed in.
Awesome, am back next week will have a closer look then. |
Ok, thank you! |
Yes at the moment the checker doesn't support anything incrementally. In fact the web playground https://kaleidawave.github.io/ezno/playground and the LSP #22 run I will double check this and it will definitely be in the next release but that may be a while as currently a bit busy with things. Thanks for the addition though :) |
Have got it compiling under WASM now. Will merge it later. I think a sort of "initial" version would be good to include in the next release. I can't think of a good way to add a test for it ATM |
Closes #164
This PR is much bigger than I intended it to be, and clones data each time a file change is observed. This could possibly be removed by changing the underlying API, but I'm honestly not sure.
Also, on every individual file change, every file that matches the glob is recompiled. I did this for 2 reasons:
My current way of supporting the glob syntax is just by using the
entry_points
provided byget_entry_points
. This seems to work pretty well, and reuses the work that needed to be done anyway to get the list of entry points. However, I'm not sure how efficient individually watching all the files is over many files.If anything needs changing, let me know! Or if this approach is terrible I'm happy to close this