Skip to content

Commit

Permalink
nitpicks
Browse files Browse the repository at this point in the history
  • Loading branch information
gggeek committed Nov 22, 2022
1 parent dd05fa6 commit c2927f1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
6 changes: 0 additions & 6 deletions Command/GenerateCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@ public function execute(InputInterface $input, OutputInterface $output)
/// @todo move these 2 params out of here, pass the context as template parameter instead
'lang' => $input->getOption('lang'),
'adminLogin' => $input->getOption('admin-login')
/// @todo should we allow users to specify this ?
//'forceSigchildEnabled' => null
);

$date = date('YmdHis');
Expand Down Expand Up @@ -384,10 +382,6 @@ protected function migrationContextFromParameters(array $parameters)
if (isset($parameters['adminLogin']) && $parameters['adminLogin'] != '') {
$context['adminUserLogin'] = $parameters['adminLogin'];
}
if (isset($parameters['forceSigchildEnabled']) && $parameters['forceSigchildEnabled'] !== null)
{
$context['forceSigchildEnabled'] = $parameters['forceSigchildEnabled'];
}

return $context;
}
Expand Down
2 changes: 2 additions & 0 deletions Command/StatusCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,8 @@ public function execute(InputInterface $input, OutputInterface $output)
->setHeaders($headers)
->setRows($data);
$table->render();

return 0;
}

/**
Expand Down
3 changes: 1 addition & 2 deletions Core/MigrationService.php
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ public function parseMigrationDefinition(MigrationDefinition $migrationDefinitio
* Note: previous API is kept for BC (subclasses reimplementing this method).
* @param MigrationDefinition $migrationDefinition
* @param array $migrationContext Supported array keys are: adminUserLogin, defaultLanguageCode,
* forcedReferences, forceExecution, forceSigchildEnabled, userContentType, userGroupContentType,
* forcedReferences, forceExecution, userContentType, userGroupContentType,
* useTransaction.
* Bool usage is deprecated. It was: when set to false, no repo transaction will be used to wrap the migration
* @param string $defaultLanguageCode Deprecated - use $migrationContext['defaultLanguageCode']
Expand All @@ -303,7 +303,6 @@ public function parseMigrationDefinition(MigrationDefinition $migrationDefinitio
* @param bool|null $forceSigchildEnabled Deprecated
* @throws \Exception
*
* @todo add support for setting in $migrationContext a userContentType, userGroupContentType ?
* @todo treating a null and false $adminLogin values differently is prone to hard-to-track errors.
* Shall we use instead -1 to indicate the desire to not-login-as-admin-user-at-all ?
*/
Expand Down

0 comments on commit c2927f1

Please sign in to comment.