-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing affordable_real
and related tests
#86
base: master
Are you sure you want to change the base?
Conversation
Adding an example to illustrate how real irreps are constructed from complex ones in the three different cases of FS=1, 0, and -1.
Add files via upload
Adding quaternionic real characters
Changing `@testset "affordable real degrees/dot"` base on new `function affordable_real`
adding a test for doubling the quaternionic characters
I also added a test in |
@kneshat thanks, tests look good! I'll squash and merge once the tests finish. |
I am wondering why tests do not work here, while "runtest.jl" works fine. Would you also run the branch |
here I need to approve tests to run, since CI services have been abused to perform computations unrelated to the package. |
test/sa_basis.jl
Outdated
@@ -157,7 +157,8 @@ end | |||
for b in sa_basisR | |||
if issimple(b) | |||
@test multiplicity(b) == size(b, 1) || | |||
2 * multiplicity(b) == size(b, 1) | |||
2 * multiplicity(b) == size(b, 1) || | |||
4 * multiplicity(b) == size(b, 1) | |||
# the first condiditon doesn't hold for realified characters; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should check the Frobenius Schur indicator here and test exactly that issimple
really does what we want
replying here to your comment (#82 (comment)) to keep the discussion related to PR in one place:
fair point with the irreducibility of characters! In the suggestion above I forgot that we already have realified the character. Taking a step back: what I want is a set of tests that will test precisely what we mean by we have essentially three cases with three different meanings of
We could wrap those checks in small functions within the testset and use them there e.g. if isirreducible(b.character)
@test multiplicity(b) == size(b, 1)
elseif _is_irr_plus_conj(b.character)
@test 2*multiplicity(b) == size(b, 1)
elseif _is_quaternionic_double(b.character)
@test 4*multiplicity(b) == size(b, 1)
else
throw("Unexpected character associated to a direct summand")
end or something along those lines |
@kneshat do you intend to work on this further, or should I carry those changes over the finish line? |
Now,
runtest.jl
works without any error.I made some changes which are as follows:
1- Modifying
affordable_real
function to cover quaternionic characters.2- Modifying
@testset "affordable real degrees/dot"
to accommodateaffordable_real
.3- Modifying
@testset "Orthogonality of projections"
to accommodateaffordable_real
.4- Removing
ex_SL(2,3).jl