Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-46065: Player shows VR button based on "360" (or variations) tag #255

Closed
wants to merge 6 commits into from
Closed

SUP-46065: Player shows VR button based on "360" (or variations) tag #255

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a264f6
SUP-46065: Player shows VR button based on "360" (or variations) tag
yambenari24 Jan 28, 2025
87868c7
fix(SUP-46065): Player shows VR button based on "360" (or variations)…
yambenari24 Feb 2, 2025
0f639b6
fix(SUP-46065): Player shows VR button based on "360" (or variations)…
yambenari24 Feb 2, 2025
fbb3ad8
fix(SUP-46065): Player shows VR button based on "360" (or variations)…
yambenari24 Feb 2, 2025
ce4e125
fix(SUP-46065): Player shows VR button based on "360" (or variations)…
yambenari24 Feb 2, 2025
bc95184
fix(SUP-46065): Player shows VR button based on "360" (or variations)…
yambenari24 Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/k-provider/ovp/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import {

export default class OVPProvider extends BaseProvider<OVPProviderMediaInfoObject> {
private _filterOptionsConfig: ProviderFilterOptionsObject = {redirectFromEntryId: true};
private _vrPluginIsOn = false
private _vrTag: string | null = null;
/**
* @constructor
* @param {ProviderOptionsObject} options - provider options
Expand Down Expand Up @@ -360,10 +362,18 @@ export default class OVPProvider extends BaseProvider<OVPProviderMediaInfoObject
if (mediaEntry.sources.captions) {
sourcesObject.captions = mediaEntry.sources.captions;
}
if (mediaEntry.metadata && typeof mediaEntry.metadata.tags === 'string' && mediaEntry.metadata.tags.split(', ').includes('360')) {
sourcesObject.vr = {};
}

if(this._vrPluginIsOn && this._vrTag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this._vrPluginIsOn is not needed

if (mediaEntry.metadata && typeof mediaEntry.metadata.tags === 'string' && mediaEntry.metadata.tags.split(', ').includes(this._vrTag)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split by "," and trim the value before checking includes

sourcesObject.vr = {};
}
Object.assign(sourcesObject.metadata, mediaEntry.metadata);
return sourcesObject;
}

// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
public _updatePlayerVrPluginIsOn(vrTag: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setVr(..)

this._vrTag = vrTag
this._vrPluginIsOn = true
}
}