Feature new slider with react-slick #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalwalt
commented
May 16, 2023
src/components/Layout.jsx
Outdated
| export default TemplateWrapper; | ||
| export const Head = () => ( | ||
| <> | ||
| <link href='https://fonts.gstatic.com' rel='preconnect' crossorigin/> |
There was a problem hiding this comment.
it seems that this has no effect. Reading this article https://www.igvita.com/2015/08/17/eliminating-roundtrips-with-preconnect/
There was a problem hiding this comment.
From Lighthouse test: Warnings: A was found for "http://cdnjs.cloudflare.com" but was not used by the browser. Only usepreconnect for important origins that the page will certainly request.
So maybe better to remove this?
to slick font
if it affect page loading
charSet instead of charset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing new components with react-slick, probably a more performant and reliable slider.